search

preda / gpuowl

GPU Mersenne primality test.
GNU General Public License v3.0
163 stars 39 forks source link

Small changes to build on Cygwin under MSWindows10 #172

Closed wedgingt closed 4 years ago

wedgingt commented 4 years ago

Queue.h - an #fidef CYGWIN to use sleep() instead of usleep(). .gitignore - add .d and a couple of files created during make. AMD3.0 - a soft link to a common place for OpenCL from AMD.

preda commented 4 years ago

Looks good with one observation: could you please drop the symbolic link -- given that it's useful only in a very particular case, it would be unsigtly for the other users.

wedgingt commented 4 years ago

I included the soft link to make it easier for users to build with the AMD SDK and easier to describe how to do that. I suspect most people won't even notice that the soft link is there without seeing it documented. But if you really don't want it included, I marked this pull request as editable by the maintainers from the start. Otherwise, I think I'd have to close/retract this pull request, drop the soft link, and create a new pull request. Unless there's a way to edit this pull request, but I don't see one.

preda commented 4 years ago

Thanks!