search

predict-idlab / powershap

A power-full Shapley feature selection method.
Other
196 stars 19 forks source link

PyPI brownout for `sklearn` in favor of `scikit-learn` #26

Closed deepandas11 closed 1 year ago

deepandas11 commented 1 year ago

Hi!

Appreciate the work on this project.

scikit-learn announced a gradual brownout of the sklearn dependency from PyPI. Even though the main branch on this repository tags scikit-learn correctly, the latest release on PyPI(rc2), still lists it as sklearn.

We had a discussion about this on this PR, but I believe a release was tagged before the sklearn -> scikit-learn change was made.

Can we expect a new release being tagged and pushed to PyPI before 12/01?

Thanks!

jvdd commented 1 year ago

Hey @deepandas11,

Thx for letting us know about the brownout :)

I just released powershap v0.0.8. Can you confirm that this version has the correct (scikit-learn) tag?

deepandas11 commented 1 year ago

I just released powershap v0.0.8. Can you confirm that this version has the correct (scikit-learn) tag?

Appreciate looking into this quickly. This works now, as expected.

Will be closing this issue.