search

predict-idlab / powershap

A power-full Shapley feature selection method.
Other
200 stars 19 forks source link

Add *kwargs to pass extra parameter to LGBMModel fit #45

Open antoniocastelli1 opened 1 year ago

antoniocastelli1 commented 1 year ago

Dear PoweShap authors,

I am Antonio, Machine Learning Scientist @ Booking.com. We found this package quite nice and useful. I have a question over the code:

https://github.com/predict-idlab/powershap/blob/4a60fbe79d67d311693e4c9a8616f81d652f2bb4/powershap/shap_wrappers/shap_explainer.py#L245

In this line the kwargs are not passed to the fit method of LGBMModel. Since they are not passed it's not possible to set extra parameter to the fit method. This means that the kwargs and **fit_kwargs specified in PowerShap class initialization are not used.

Could you please check and maybe fix this in a new release.

Cheers

Antonio