search

predict-idlab / powershap

A power-full Shapley feature selection method.
Other
193 stars 18 forks source link

Fix wrong aggregation of shap values #52

Closed jvdd closed 4 months ago

jvdd commented 4 months ago

Fix a bug introduced in #49

jvdd commented 4 months ago

Fixes bug introduced in this line https://github.com/predict-idlab/powershap/pull/49#discussion_r1584839006

jonasvdd commented 4 months ago

@jvdd, maybe just add a comment / sanity check on which dimensions you might expect You could also include an assert regarding the dimensions