predictionmachine / pm-github-actions

Repository for common GitHub Actions workflows for Prediction Machine
MIT License
3 stars 1 forks source link

Try flakehell for flake8 and black via reviewdog in workflow #42

Closed abhishekmishragithub closed 3 years ago

abhishekmishragithub commented 3 years ago
tchklovski commented 3 years ago

I was able to get flakehell working by adding:

[tool.flakehell]
# flake8==3.9.0 did not need this, see https://githubmemory.com/repo/flakehell/flakehell/issues/10
extended_default_ignore=[]

to pyproject.toml. would be nice to ditch setup.cfg

abhishekmishragithub commented 3 years ago

As discussed with @tchklovski, we are dropping flakhell because of following reasons:

  1. not maintained,
  2. only 222 stars,
  3. does not actually seem to function reliably
  4. all the checks can be done with flake8

We had issues while running flake8 plugins with flakehell.