predixdesignsystem / px-breadcrumbs

https://www.predix-ui.com/#/elements/px-breadcrumbs
Apache License 2.0
0 stars 2 forks source link

Fix dynamic import issue #14

Closed shinxi closed 6 years ago

shinxi commented 6 years ago

@davidrleonard @randyaskin Hi David/Randy, our team depends on dynamic import to use Predix-ui components at React, so far most components have been tested out successfully, that'll be very appreciated if this PR can get merged to fix issue #13. Thanks, Jonathan

davidrleonard commented 6 years ago

This makes sense to me. See https://eslint.org/docs/rules/no-use-before-define. Thanks for the contribution @shinxi. Need to see why the test are failing then we can merge. Test fail might be unrelated to this change. I’ll check back today.