Fix custom keys support

predixdesignsystem / px-breadcrumbs

Apache License 2.0

0 stars 2 forks source link

Closed davidrleonard closed 6 years ago

davidrleonard commented 6 years ago

Adds support for developer-specified keys in the items passed in, fixes #16.

randyaskin commented 6 years ago

Looks good to me, works on my machine. Two questions/ideas:

Many of our components have a /demo/simple_demo.html instead of the examples folder you've created here, maybe it makes sense to standardize? (git blame Kate for the underscore, when all the other file names use dashes).
You could add a prop/binding for keys to the demo page so it's demo-able and easier to test.

davidrleonard commented 6 years ago

Not sure on /demo/simple_demo.html vs. examples/, I've made a ton of examples/ all over (oops didn't realize we had the other convention). I'm open to whatever you think we should do, LMK.
Keys are not reaaalllyyy dynamic, so if we add it to the demo we need to do some magic to completely redraw the breadcrumbs. We recommend setting them early and forgetting them, so I'm leaning against making them an interactive demo prop. Thoughts?

randyaskin commented 6 years ago

Ah yeah, good point. Forgot about that. 👍