search

predixdesignsystem / px-breadcrumbs

https://www.predix-ui.com/#/elements/px-breadcrumbs
Apache License 2.0
0 stars 2 forks source link

Need a unique event to notify me when a user clicks on an item #21

Closed colinjlacy closed 6 years ago

colinjlacy commented 6 years ago

Expected behavior and actual behavior:

When I'm using this component, I have to pass in an array of items for the selected-route in order for the breadcrumbs to display as expected. Similarly, I have to listen for emits of the selected-changed event to know when a user has interacted with the component, and to route them accordingly. I'm currently seeing a selected-changed event being emitted for both cases - when the binding data indicating the selected-route changes, and when the user clicks on an item. I would expect to see two different events - specifically one that is unique for user-based interaction, similar to what is done in the px-app-nav with the px-app-nav-item-tapped event.

randyaskin commented 6 years ago

screen shot 2018-01-12 at 2 16 08 pm

colinjlacy commented 6 years ago

damn

randyaskin commented 6 years ago

There's a bug in the Google analyzer that builds our API pages, but the description for that event should read: This event is fired whenever a click occurs - from a top path item, or dropdown item - that changes the context. The new context is attached as 'item'

colinjlacy commented 6 years ago

gotcha. thank you sir!