predixdesignsystem / px-breadcrumbs

https://www.predix-ui.com/#/elements/px-breadcrumbs
Apache License 2.0
0 stars 2 forks source link

Error checking or error logging should be implemented to confirm the route is valid. #6

Open ppeyro opened 7 years ago

ppeyro commented 7 years ago

Expected behavior and actual behavior:

A non-existent/mistyped “id” specified in selected-route currently fails silently. It results in a blank breadcrumb and no errors in log, no indications what went wrong.

Environment:

px-breadcrumbs: redesign Browsers: Chrome

Screenshot:

screen shot 2017-07-27 at 4 23 47 pm

Code Example:

      <h3>Invalid selected_route</h3>
      <div>
        <px-breadcrumbs
          items="{{items}}"

          selected-route='["id1","id2","id3","id4","id5","id6","idinvalid"]'
          search-mode="true"
          enable-warnings="true"

        >
      </px-breadcrumbs>
    </div>

/cc @davidrleonard