search

predixdesignsystem / px-data-grid

Predix UI component which defines a data grid
https://www.predix-ui.com/#/elements/px-data-grid
Apache License 2.0
12 stars 20 forks source link

Added the code to set the required height to vaadin-grid #807

Closed odelu closed 6 years ago

odelu commented 6 years ago

The height: auto of vaadin-grid is not working properly in firefox. Please see the below screen for reference. image

If I want to set my specific height to that vaadin-grid by passing gridHeight parameter, Currently it is not being set to our specific height. By default 400px is being set as per the css which is mentioned in vaadin-grid component.

Now here we are enabling to set the our required height to vaadin-grid when the gridHeight is passed from my application (PETC).

cla-bot[bot] commented 6 years ago

Thank you for your pull request. We require contributors to sign our Contributor License Agreement here.

odelu commented 6 years ago

The issue is not happening in the Firefox nightly so most likely will be fixed in the next Firefox release. Hence this can be deferred until then.