predixdesignsystem / px-data-grid

Predix UI component which defines a data grid
https://www.predix-ui.com/#/elements/px-data-grid
Apache License 2.0
12 stars 20 forks source link

Workaround for item-action and item-save events not propagating to component root on Shady DOM #811

Closed evanjd closed 6 years ago

evanjd commented 6 years ago

Fixes https://github.com/predixdesignsystem/px-data-grid/issues/805

On polyfilled browsers, composed custom events do not propagate across the full composed path - instead they're swallowed once they hit the vaadin-grid element.

Though I think it's likely this is a Shady DOM bug, I've only been able to reproduce it with the vaadin-grid component so far. I do intend to raise this up (either on webcomponentsjs, shadydom or vaadin) but I need a little more time to throw together a clean JS fiddle to reproduce this.

For the short term, I've worked around this by dispatching the item-action and item-save events from vaadin-grid instead of a component nested within it. I've also added a couple tests for this issue, and tweaked travis/wct to get tests passing across all platforms.