search

predixdesignsystem / px-vis-xy-chart

For a live demo of this predix UI component, visit
https://www.predix-ui.com/#/modules/px-vis-xy-chart
Apache License 2.0
1 stars 20 forks source link

showing/hiding series bar rect on y axis not configurable via property #12

Closed learner1024 closed 7 years ago

learner1024 commented 7 years ago

Issue: showing/hiding series bar rect on y axis not configurable via property (https://github.com/PredixDev/px-vis-xy-chart/issues/11)

To entirely fix this, there are two required changes one is px-vis-axis.html that is part of px-vis repo Here is pull request for that change https://github.com/PredixDev/px-vis/pull/69

second one is, here, i.e. exposing properties. In our case, we are going to have only one series, and series bar may not be necessary, hence having a config property should be good.

Hope this helps, Sandeep Khandewale (Consultant, GE Oil and Gas, Mumbai)

nonmetalhail commented 7 years ago

Hi, thanks but this is intentional. Rather than exposing every property on every component, it is easier to use a configuration object to configure the sub components. Please use the x-axis-config and y-axis-config objects.