preeti13456 / CityonBikes

Creative Commons Zero v1.0 Universal
8 stars 27 forks source link

Updated README.md, SETUP.md and Requirements.txt #69

Closed vismitap closed 3 years ago

vismitap commented 3 years ago

Fixed # 47

Related Issuse or bug

Fixes: #[47]

Describe the changes you've made

Please note the changes made: 1) The asgiref==3.2.7 is also outdated and cannot work with theDjango==3.1.4 specified in the same requirements.txt causing conflicts.

ERROR: Cannot install -r requirements.txt (line 3) and asgiref==3.2.7 because these package versions have conflicting dependencies.

The conflict is caused by:
The user requested asgiref==3.2.7
django 3.1.4 depends on asgiref<4 and >=3.2.10
So updated `asgiref==3.2.7` also to `asgiref==3.3.1` in requirements.txt. 

2) The latest version of wheel and pillow also added to resolve similar errors.

All these changes ensure the successful installing of dependencies.

3) As per this changed the setup.md slightly: python manage.py createsuperuser was changed to winpty python manage.py createsuperuser.

4) Finally updated README.md accordingly.

Type of change

Please delete options that are not relevant.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

Screenshots

Original Updated
original screenshot updated screenshot
vismitap commented 3 years ago

I messed up with setting upstream as I did not checkout to main branch and hence could not pull and push code for another PR. I had to delete the earlier fork. I am coming with a fresh PR for #47 . Please review new PR #72. Sorry for the inconvenience 😓