prefiks / u2f4moz

U2F support extension for Firefox
GNU Lesser General Public License v2.1
197 stars 15 forks source link

Version field included in RegistrationRequest? #57

Open justinmayer opened 7 years ago

justinmayer commented 7 years ago

When using this add-on with Firefox 52 to add a U2F device to the demo web application provided by django-u2f, an error is raised due to a missing required version field.

I filed an issue report in order to learn more about the error, and the django-u2f project author raised the question as to whether the U2F specification considers version to be a required field. As far as I can tell by looking at the specification, it appears that version is indeed intended to be a required field in the context of a RegistrationRequest: https://fidoalliance.org/specs/fido-u2f-v1.1-id-20160915/fido-u2f-javascript-api-v1.1-id-20160915.html#u2f-operations

If that is the case, I have two questions:

  1. Is this add-on not currently including a version field in its request when adding a device?
  2. If not, do you think a version field could be added to registration requests?
justinmayer commented 7 years ago

Hi @prefiks. Do you think you could take a moment to share your thoughts regarding this issue?

baloo commented 7 years ago

As far as I understand the code, the problem lies in the libu2f-host. It does not reply with the version.