prefiks
commented
8 years ago Hello,
Right now those binaries are a bit modified version of upstream libu2f-host, and with some tweaks to js side i could use upstream versions, but i am working on new version that will have more significant differences vs upstream version (i am making it be able to discover when device appears or is removed, so it will ask you to plug device if one is not already available)
This patch looks ok to me, will apply.
Thank you very much for making this extension. I was going to do it myself as a weekend project so people would stop spamming the Bugzilla bug.
I have setup ESLint to make for more consistent style.
I have some other suggestions:
Also, did you customize the c_src directory at all? Have you considered looking for the appropriate binaries already installed on the PATH instead of packaging your own? The extension could optionally download the binaries separately.