Open eunos-1128 opened 2 weeks ago
Maybe @h-vetinari can comment on wether we need to set both values or if one should be enough. I am not sure!
I believe you need to set both. But I am verifying with @h-vetinari and others. Thanks for testing!
No, it should be enough to set just c_stdlib_version. We have logic in smithy that will still populate both values in the variant config though, because the CI setup still relies on MACOSX_DEPLOYMENT_TARGET.
We did update the logic in staged-recipes as well (which isn't using the general ci setup), I'd have to take a look what goes wrong there
Did you open a PR for this already? I cannot find it on https://github.com/conda-forge/staged-recipes. It's possible that local builds are missing the logic I mentioned, but it should definitely be there for the actual CI runs.
I've had opened https://github.com/conda-forge/staged-recipes/pull/27710, but changed to conda-build
instead of rattler-build
due to this error.
I think I understand what happens:
conda_build_config.yaml
fine, and writes the additional deployment target key by appending to the conda_build_config.yaml
file.conda_build_config.yaml
file though, so it's not picked up.rattler-build
would automatically use the variants.yaml
but then we run into additional problems by having to support two formats.
Even when I used variants.yaml
instead of conda_build_config.yaml
, it didn't work.
Yes, with variants.yaml
the problem is that in staged-recipes the automation only looks at conda_build_config.yaml
so it will never "magically" add the MACOS_DEPLOYMENT_TARGET
...
I see.
No, it should be enough to set just c_stdlib_version. We have logic in smithy that will still populate both values in the variant config though, because the CI setup still relies on MACOSX_DEPLOYMENT_TARGET.
We did update the logic in staged-recipes as well (which isn't using the general ci setup), I'd have to take a look what goes wrong there
This means the problem ie fixed now?
It's not fixed yet. We either need to support variants.yaml
in conda-forge, or we need to support conda_build_config.yaml
in rattler-build. :)
I encountered an issue where the build of a package for MacOS failed because
MACOSX_DEPLOYMENT_TARGET
was not set to the same version, even thoughc_stdlib_version
was set in the conda_build_config.yaml.conda-forge recipe I used
I don't know exactly why, but is this a kind of bug?