Open h-vetinari opened 4 months ago
I'll take a look!
OK, actually there is no bug because the if: linux
is for the target_platform
(emscripten) and not the build_platform
.
You should be able to fix the issue by using build_platform == "linux-64"
It's a little confusing, but it's also consistent with the rest of the recipe, so not sure what to do here. Ideas welcome!
It also makes me realize that it's not easy to check wether the build_platform
is unix, or linux. Maybe we should add is_linux(build_platform)
, or is_unix(build_platform)
functions ...
We could also add a starts_with
filter to minijinja :)
OK, actually there is no bug because the
if: linux
is for thetarget_platform
(emscripten) and not thebuild_platform
.You should be able to fix the issue by using
build_platform == "linux-64"
OK, that makes sense of course! Clearly I'm not yet used to the test section having a build section as well! π
+1 to the other jinja enhancements too!
We could also add a
starts_with
filter to minijinja :)
There is a startingwith
test in minijinja:
build_platform is startingwith('linux')
Hi! π
I'm starting to work on emscripten-forge a bit these days, and ran into the following problem, where @DerThorsten asked me to raise an issue.
In our pyjs recipe, there's the following:
however, despite being on linux, my test environment mis-detects the condition:
which unsurprisingly installs:
removing the
if: linux
portion makes the constraints work again.