search

prefix-dev / rip

Solve and install Python packages quickly with rip (pip in Rust)
https://prefix.dev
BSD 3-Clause "New" or "Revised" License
653 stars 23 forks source link

misc: improve logging level of wheel build failures #166

Closed tdejager closed 9 months ago

tdejager commented 9 months ago

I we find metadata for an artifact it does not really matter that the others have errored out I think. But if we cannot find any then we want to make this into an error, because currently the thread will panic after this happens.

This should also enable pixi users to see this error.

wolfv commented 9 months ago

Nice! Does this also show the stderr of the Python process to the user?

tdejager commented 9 months ago

Nice! Does this also show the stderr of the Python process to the user?

It does yes. I don't know if I'm able to filter that. Most of the time it's no that interesting.

ruben-arts commented 9 months ago

Seeing this should we also allow the warnings from rip to be shown in pixi?

tdejager commented 9 months ago

Seeing this should we also allow the warnings from rip to be shown in pixi?

I think we should use warnings to show that we skipped packages, but can potentially still solve, and errors that we will be unable to solve. So I think its fine for now.

tdejager commented 9 months ago

I'll just merge this for now, seeing as it was approved and we can improve on it later @wolfv.