search

prefix-dev / setup-pixi

GitHub Action to set up pixi :octocat: 📦
https://pixi.sh/dev/advanced/github_actions
BSD 3-Clause "New" or "Revised" License
56 stars 10 forks source link

Add support for --locked and --frozen #21

Closed pavelzw closed 1 year ago

pavelzw commented 1 year ago

setup-pixi uses --locked by default now. This breaks setup-pixi for pixi<0.5.0. To still use pixi<0.5.0, you need to specify locked: false.

ruben-arts commented 1 year ago

You're quick! Wouldn't you want it to fail if the lock file is outdated as default?

pavelzw commented 1 year ago

I personally would prefer a working CI even though the lockfiles are not up-to-date (i mean everything is working after all, it's just not at up to date 😅). If we use --locked by default, this would probably result in a lot of red CI over time that would need to be investigated for no reason.

IMO dependabot or renovate should update the lockfile instead every week or so 🤷🏻

ruben-arts commented 1 year ago

Ah I think you have a different idea of an out of date lockfile.

If you specify python >= 3.11 in your pixi.toml and your lockfile holds python = 3.11.0. Then this lockfile is up to date, and can stay --locked. Even if there would be a 3.11.1 available.

Only when you specify a >= 3.12 in your pixi.toml with a python = 3.11.0 in your pixi.lock the --locked will fail. So this should only give you "red CI" if you updated your pixi.toml without also updating the pixi.lock.

pavelzw commented 1 year ago

Ah, I see! Maybe we should write down this notion in the pixi docs 😅