search

prefix-dev / setup-pixi

GitHub Action to set up pixi :octocat: 📦
https://pixi.sh/dev/advanced/github_actions
BSD 3-Clause "New" or "Revised" License
56 stars 10 forks source link

Add better support for pyproject.toml pixi projects #87

Closed ruben-arts closed 7 months ago

ruben-arts commented 8 months ago

If updating documentation:

Fixes #88

pavelzw commented 8 months ago

Hmm, i'm wondering whether we should make this behavior implicit without the need to specify manifest-path...

ruben-arts commented 8 months ago

I think we should, but we could make it a next step, just wanted to make sure there was an answer to the question on how to do it.

ruben-arts commented 7 months ago

How do i trigger the full CI? :sweat_smile:

ruben-arts commented 7 months ago

Oeh I don't like to add a npm install to all these tests. You okay without reading the toml? @pavelzw

pavelzw commented 7 months ago

@ruben-arts you need to force tsup to include toml in the transpiled code. https://github.com/prefix-dev/setup-pixi/blob/4fc8d82a01877bbbcb485e8282bd48539d8adc84/tsup.config.js#L15-L23

We should look how much larger the transpiled code will be; if it's too much we could also just read the file and check if [tool.pixi.toml] is contained in there

ruben-arts commented 7 months ago

The index.js has grown with 0.12 Mb.

pavelzw commented 7 months ago

I think that's okay 👍🏻

ruben-arts commented 7 months ago

@pavelzw This should be good now.

ruben-arts commented 7 months ago

Thanks for the support @pavelzw, learned a lot about action development!