prefixcommons / biocontext

JSON-LD Contexts for Bioinformatics Data
22 stars 18 forks source link

Revise Wormbase URI #32

Closed RichardBruskiewich closed 3 years ago

RichardBruskiewich commented 3 years ago

... to reflect the simpler one in Identifiers.org

RichardBruskiewich commented 3 years ago

unfortunately you can't edit here, this has to be edited upstream, this file is derived cc @deepakunni3 @kshefchek

Hi @cmungall, actually .. you'll note in the original issue that I also already issued a PR request to the PrefixCommons biocontext for Monarch at https://github.com/prefixcommons/biocontext/pull/32 for this change. If @deepakunni3 @kshefchek have commit/merge access to the PrefixCommons repo, then they can process the PR and I can revert this Biolink Model YAML file prefixes section change.

deepakunni3 commented 3 years ago

@kshefchek Would be great to get your feedback on how to handle this change.

kshefchek commented 3 years ago

the workflow for changing the monarch context is requesting a change to this file - https://github.com/monarch-initiative/dipper/blob/master/dipper/curie_map.yaml, and then regenerating the the context ld file here (although I think we've meant to automate this step).

RichardBruskiewich commented 3 years ago

the workflow for changing the monarch context is requesting a change to this file - https://github.com/monarch-initiative/dipper/blob/master/dipper/curie_map.yaml, and then regenerating the the context ld file here (although I think we've meant to automate this step).

Thanks @kshefchek (cc: @cmungall @deepakunni3), I've created a fresh PR https://github.com/monarch-initiative/dipper/pull/1000.

I'll go ahead and cancel/close every other related issue/PR

RichardBruskiewich commented 3 years ago

Proposed change kicked over to https://github.com/monarch-initiative/dipper/pull/1000.

Sorry... didn't fully understand the chain of causality here!