prefrontalcortex / UnityGLTF

Runtime GLTF Loader for Unity3D
MIT License
163 stars 41 forks source link

Server build fails due to missing TargetCurveSet in ExporterAnimationHumanoid #57

Closed davidyrgilbert closed 2 years ago

davidyrgilbert commented 2 years ago

In the latest dev, the following issue gets thrown:

Library/PackageCache/org.khronos.unitygltf@a88b38b642/Runtime/Scripts/SceneExporter/ExporterAnimationHumanoid.cs(14,102): error CS0246: The type or namespace name 'TargetCurveSet' could not be found (are you missing a using directive or an assembly reference?)

Looking at the code this is quite straightforward: TargetCurveSet is only defined when ANIMATION_SUPPORTED is true, which for my build (dedicated server) it isn't. The corresponding line in ExporterAnimationHumanoid however isn't in an #if block, which then fails.

davidyrgilbert commented 2 years ago

And I just saw that you fixed this yesterday already <3

hybridherbst commented 2 years ago

Yep! Sorry for the intermittent build failure :) Still trying to move rather fast, I hope releases will stabilize soon in preparation for / as part of the merge back to the KhronosGroup repo.