prefrontalcortex / UnityGLTF

Runtime GLTF Loader for Unity3D
MIT License
163 stars 41 forks source link

PlayableGraph was not destroyed. #89

Open xtc06 opened 1 year ago

xtc06 commented 1 year ago

Hi,

Hello, I wrote some code to export, it works very well, but I have the message : PlayableGraph was not destroyed. My code : ExportOptions exportOptions = new ExportOptions(); exportOptions.MergeClipsWithMatchingNames = true; GLTFSceneExporter exporter = new GLTFSceneExporter(gameObject.transform, exportOptions); exporter.SaveGLB(path, fileName);

I can't use using, destroy or dispose for GLTFSceneExporter, am I doing something wrong?

hybridherbst commented 1 year ago

Hey, which version/commit are you on? There's a version/2.x branch with more improvements by now, so would be great if you could test on that and ideally also on latest 1.x, 1f5c1a2d294fe4c618d97bbfac2c8a8a72e33a0c.

That message would mean that something in your export is using humanoid rigs, which is supported, but there were some versions where it produced an error similar to what you've posted.

xtc06 commented 1 year ago

I added the package from this URL : https://github.com/prefrontalcortex/UnityGLTF.git?path=/UnityGLTF/Assets/UnityGLTF The version : 1.24.0-pre.2

hybridherbst commented 1 year ago

Can you try either https://github.com/prefrontalcortex/UnityGLTF.git?path=/UnityGLTF/Assets/UnityGLTF#release/2.0.3-exp or https://github.com/prefrontalcortex/UnityGLTF.git?path=/UnityGLTF/Assets/UnityGLTF#release/1.24.2-pre?

xtc06 commented 1 year ago

Thanks I will try :)

xtc06 commented 1 year ago

I will test when the repository will be accessible again ^^

hybridherbst commented 1 year ago

Sorry, typo! I meant from the prefrontal cortex fork, I updated the URLs above

xtc06 commented 1 year ago

I just tested the 2.0.3-exp, the problem persists.

hybridherbst commented 1 year ago

Thank you - then it would be great if you could send me a zipped project (without Library folder etc.) where the error reproduces when exporting a file and some steps. Thanks!

xtc06 commented 1 year ago

Yes as soon as I have time I will prepare a file for you. I tested (the 2.0.3-exp) on another scene, with a new script and a new FBX to export, the problem no longer seems to be present, the scene that is causing me problems contains a fbx rigger, content elements in the bones when they are dissable, create error logs during the export, and the meshes have an UNorm8 color format which also poses a problem during the export, I wonder if the problem does not come from that :)

hybridherbst commented 1 year ago

Thanks for the additional info - yes, the issue is most likely from some Animation Rigging combination, that's pretty much the only case where a playable graph is directly sampled on export. So a repro file would be well appreciated!

And if you can open another issue about the UNorm8 issues that would be appreciated too!

xtc06 commented 1 year ago

Yes the problem comes from the animations. I'm on unity 2021.3.22f1 URP.

PlayableGraph.zip

hybridherbst commented 1 year ago

Hey @xtc06 I was finally able to look at your report, however there's not a complete file in the zip - the model is missing bones, so I can't reproduce your issue. Would be great if you could export as .unitypackage so I can reproduce here. Thanks!

xtc06 commented 1 year ago

I will do what is necessary when I have a little more time available, unfortunately I have a lot of work at the moment, but I promise to do it as soon as possible :)