preinheimer / xhprof

XHGUI is a GUI for the XHProf PHP extension, using a database backend, and pretty graphs to make it easy to use and interpret.
Other
834 stars 185 forks source link

Warnings during request display on single run page #86

Closed aik099 closed 9 years ago

aik099 commented 9 years ago

The page call I was profiling was a form submit of 3 dimensional array. The code, that prints it https://github.com/preinheimer/xhprof/blob/master/xhprof_lib/templates/single_run_header_block.phtml#L132 presumes that array can't contain sub-arrays in it and uses implode on it. That in turn triggers a warning about array to string conversion.

I'm willing to make a PR with a fix, but currently the only idea I have is to display print_r output instead of doing implode.

aik099 commented 9 years ago

@preinheimer ping.

preinheimer commented 9 years ago

So we've got a few options I guess.

Recursion seems like the most work, and the most useful :/

aik099 commented 9 years ago

PR created.