mailchimp emails - Githubissues

premAI-io / state-of-open-source-ai

:closed_book: Clarity in the current fast-paced mess of Open Source innovation

https://book.premai.io/state-of-open-source-ai

Other

1.52k stars 89 forks source link

mailchimp emails #114

Closed casperdcl closed 10 months ago

casperdcl commented 10 months ago

used a form rather than js fetch to circumvent mailchimp's CORS
discard mailchimp response (render in hidden iframe)
continue using original endpoint for basic validation checks

the above hacks are necessary since (afaik) mailchimp doesn't provides a proper JSON API with configurable CORS, and we don't want to hardcode API keys here. Less hacky solutions are welcome /CC @Janaka-Steph :)

filopedraz commented 10 months ago

To me looks good, but I would like @Janaka-Steph opinion on this.

filopedraz commented 10 months ago

@casperdcl can you paste here the Form layout? Did you manage to replicate it the same as the form we were having in Mailchimp?

casperdcl commented 10 months ago

this is what the modal looks like; basically same as before...

filopedraz commented 10 months ago

LGTM. Let's merge