search

premail / premail

An easy-to-use component-based build system for MJML, the email templating language, with Handlebars templating, Sass styles, and extra options.
https://premail.dev
GNU Affero General Public License v3.0
43 stars 1 forks source link

Reset defaults on all `<mj-wrapper>` elements in `index.hbs` #67

Closed rootwork closed 2 years ago

rootwork commented 2 years ago

Type of feature

Describe the feature

MJML sets defaults on <mj-wrapper> to padding="20px 0" and text-align="center".

This might be MJML's default, but it can be surprising to someone new who is wondering where all this extra padding and centered text is coming from. And while MJML also sets similar defaults on things like <mj-section>, those things exist (and are easily configurable) in Premail's content and structure partials. The wrappers, however, exist in index.hbs itself, which we point to for theming only as a last resort. So let's set more logical HTML defaults (no padding, left-aligned text) for wrapper elements that appear here.

rootwork commented 2 years ago

Update: There are some other elements too, like <mj-section> in the salutation and the <mj-column> in the social links. Unless these are configurable in designConfig.yaml, they should be reset in index.hbs as well.

github-actions[bot] commented 1 year ago

Issue closed and locked due to lack of activity. If you encounter this same issue, please open a new issue and refer to this closed one.