premailer / actionmailer_inline_css

Seamlessly integrate Alex Dunae's premailer with ActionMailer.
http://madebynathan.com
MIT License
75 stars 25 forks source link

Warning raised by Mail gem from test nlineCssHookTest#test_inline_css_hook_with_utf_8_characters #8

Closed leehambley closed 12 years ago

leehambley commented 12 years ago
$ rake TESTOPTS="-v"
Loaded suite /Users/codebeaker/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/rake-0.9.2.2/lib/rake/rake_test_loader
Started
InlineCssHookTest#test_inline_css_hook_with_base_url: 0.17 s: .
InlineCssHookTest#test_inline_css_hook_with_only_html_part: 0.03 s: .
InlineCssHookTest#test_inline_css_hook_with_text_and_html_parts: 0.06 s: .
InlineCssHookTest#test_inline_css_hook_with_utf_8_characters: Non US-ASCII detected and no charset defined.
Defaulting to UTF-8, set your own if this is incorrect.
0.03 s: .
InlineCssHookTest#test_preservation_of_attachments: 0.07 s: .
PremailerStylesheetLinkTagTest#test_premailer_stylesheet_link_tag: 0.07 s: .

Finished in 0.436325 seconds.

6 tests, 11 assertions, 0 failures, 0 errors, 0 skips

Test run options: --seed 439 --verbose

Perhaps one aught to take something like silence_warnings from ActiveSupport, or a simpler implementation, without having to pull in an extensive dependency.

Wherever the Mail gem is producing the messages

Non US-ASCII detected and no charset defined.
Defaulting to UTF-8, set your own if this is incorrect.

Should be silenced in these tests.

ndbroadbent commented 12 years ago

Hi, thanks for your interest! Those UTF-8 warnings are fixable, and I have previously fixed them like this: 4c92dc290b760d7545818e74a5f7275f577093a5

leehambley commented 12 years ago

Cool, I'll tweak my patch, as I mentioned in the pull req. was hacking late at night and looking for success more than perfection, will adapt and come back with some additional tests.