RuleSet#create_dimensions_shorthand! fails for certain properties

premailer / css_parser

Ruby CSS Parser

Other

279 stars 110 forks source link

RuleSet#create_dimensions_shorthand! fails for certain properties #81

Closed EBashkoff closed 7 years ago

EBashkoff commented 7 years ago

RuleSet#split_declaration raises an error: ArgumentError: comparison of Fixnum with nil failed for certain situations where @declarations[dest] or @declarations[src] has no :order key and the comparison > in split_declaration cannot compare an integer value to a nil value.

Please see https://github.com/premailer/css_parser/pull/80.

Thank you!!

EBashkoff commented 7 years ago

Closed this issue. Problem was already solved in v1.4.6. See note in https://github.com/premailer/css_parser/pull/80

grosser commented 7 years ago

❤️ thx for investigating :)