search

premailer / css_parser

Ruby CSS Parser
Other
279 stars 110 forks source link

Added check for content type for remote files #98

Open bsislow-or opened 6 years ago

bsislow-or commented 6 years ago

Issue Resolution:

When parsing a file with invalid html, there is a possibility that the following html could be parsed:

<link rel="stylesheet" type="text/css" href="SomeFont.otf">

The above is a css link tag with a font as the href In this case the parser will pull down the file and attempt to process it. There are certain cases where this takes a non trivial amount of time to parse and can even stall out applications waiting for the parser to complete based on the contents of the font or non css file.

Since this should not handle invalid file types, this PR checks for the proper content type and responds with a RemoteFile Error