search

premake / premake-core

Premake
https://premake.github.io/
BSD 3-Clause "New" or "Revised" License
3.22k stars 620 forks source link

Remove outdated repositories #1297

Closed starkos closed 5 years ago

starkos commented 5 years ago

I'd like to remove the old repositories that have been moved into core:

These two aren't in core, but haven't had any activity in quite a long time. I was leaning toward removing them as well, but now in discussion below:

This one also hasn't had any activity, and I don't believe ever fulfilled its intended purpose. The examples have fallen out of date and aren't being maintained. I'd vote to remove:

A bit of background: most of these modules lived most of their lives as part of the main Premake code. I had an idea a while back that it might help the project scale if they were broken out: I could focus on the core code, and others could specialize on the individual modules. It turned out to be a maintenance nightmare, and all of the code was moved back into core.

So these repositories only represent a short window of time relative to their overall development. It is confusing to have them living alongside their "real" counterparts. And I believe it gives the wrong impression, and it makes it look like those features haven't seen any improvement in years.

Thoughts or objections?

Croydon commented 5 years ago

I'm obviously an outsider to the premake project, but in general I'm considering deleting code history as a terrible idea.

Why not just archive them?

starkos commented 5 years ago

Fair question. I've gone ahead and "archived" them so folks can see what that looks like. It definitely helps, but I still question the value of their existence. I'll keep this issue open a while and see what other people think.

At the very least, I feel pretty strongly that premake-cookbook needs to go, as those samples are just falling farther and farther out of date. Good idea, wrong execution.

TurkeyMan commented 5 years ago

I'd like my ones back if you wanna delete them from the org. That is, eclipse and monodevelop, which aren't in core. That eclipse one in particular was painstaking to get working as much as it is... it needs work, but the foundation is comprehensive.

ratzlaff commented 5 years ago

I like the idea of premake-cookbook - as in some non trivial configurations for getting certain things done or seeing how certain api features are used.

But yea, they are not maintained so its hard to justify keeping them around in their current state.

starkos commented 5 years ago

Apologies @TurkeyMan, I was certain MonoDevelop was in core already! I've update the issue description.

What do you think about removing the modules that are now back in core?

What do you think should happen to eclipse and monodevelop? Do they work against the latest premake-core? I see no real harm in leaving them as-is if they are functional, but if no one is able to maintain them perhaps they should be moved out?

samsinsane commented 5 years ago

@TurkeyMan FWIW, MonoDevelop is dead and the later versions of it used the same output as the VS generator. @starkos with that knowledge, the monodevelop module working against latest or not is irrelevant - it was also broken for over a year before anybody noticed so again, it's irrelevant as it impacts nobody.

I don't really see the point in deleting any of the repos, I think archiving them would suffice, If someone wants to fork them, or transfer them that should still be possible after they're archived. I tend to agree with the above about the history, I believe only the Android module was added with history, so we've lost the commits for other modules.

starkos commented 5 years ago

Cool cool, I'll leave them archived.