search

premake / premake-core

Premake
https://premake.github.io/
BSD 3-Clause "New" or "Revised" License
3.13k stars 611 forks source link

Update Emscripten extension fork in modules.md #2206

Closed tritao closed 1 month ago

tritao commented 2 months ago

This just updates the URL to my fork, which is an up to date and mantained version.

KyrietS commented 2 months ago

Could we ask the original author (@TurkeyMan) to mention your fork as an actively maintained successor in his README.md, if that is his wish? I think that would be more fair.

Also, I could use some help in verifying the legitimacy of your fork (which is 2 days old).

BTW you seem to be very fond of forking projects. You have over 100 of them...

tritao commented 2 months ago

Could we ask the original author (@TurkeyMan) to mention your fork as an actively maintained successor in his README.md, if that is his wish? I think that would be more fair.

Sure, that's fair. But given the latest contribution has been 5 years ago (which in fact was actually a PR of mine fixing someting) might be a tell it's not mantained any more. I actually opened a PR on their repository with one of the new fixes, but realized it would be best to fork after I needed a bunch more commits and would need to send either a big blob PR or open a bunch of individual PRs.

The goal of this was to help new users find a version that is more mantained, just trying to help the community. If this turns out to be such a contentious issue, I don't really mind just closing this PR.

Also, I could use some help in verifying the legitimacy of your fork (which is 2 days old).

Can't see the relevancy of the age of the fork. What kind of help do you need? Just look at the changes: https://github.com/TurkeyMan/premake-emscripten/compare/master...tritao:premake-emscripten:next

BTW you seem to be very fond of forking projects. You have over 100 of them...

Again, I see no relevancy of this to this at all.

KyrietS commented 2 months ago

Sorry if I sounded harsh. I've never used emscripten before, so even though I can see the code, I just have to trust that it will work. I just want to be careful, hence my skepticism 😅

Let's give @TurkeyMan a week to respond and if there is no response, we will just merge your PR.

Anyway, thanks for sharing your patched premake-emscripten extension 🤗