premake / premake-core

Premake
https://premake.github.io/
BSD 3-Clause "New" or "Revised" License
3.2k stars 618 forks source link

Nuget not importing all props in vcxproject #2227

Closed simco50 closed 2 months ago

simco50 commented 2 months ago

What seems to be the problem? When adding a nuget package to the config, the .vcxproj doesn't contain all properties it should have.

What did you expect to happen? I expect the generated project file to contain the same properties compared to when adding nuget packages through Visual Studio.

What have you tried so far? Manually adding the missing properties leads to getting the expected result in Visual Studio.

How can we reproduce this?

Project generation:

In particular, this property is missing:

<Import Project="packages\Microsoft.Direct3D.D3D12.1.614.1\build\native\Microsoft.Direct3D.D3D12.props" Condition="Exists('packages\Microsoft.Direct3D.D3D12.1.614.1\build\native\Microsoft.Direct3D.D3D12.props')" />

For comparison (not premake):

What version of Premake are you using? 5.0.0-beta2

simco50 commented 2 months ago

Looks like commit 53bc271 fixed this issue. There hasn't been a release since.