premake / premake-core

Premake
https://premake.github.io/
BSD 3-Clause "New" or "Revised" License
3.22k stars 620 forks source link

cppdialect "C++11" generates CLANG_CXX_LANGUAGE_STANDARD = "C++11" (uppercase) for Xcode 4 #895

Closed hsandt closed 7 years ago

hsandt commented 7 years ago

Both cppdialect "C++11" and cppdialect "c++11", resp. 14, 17 generate build configurations CLANG_CXX_LANGUAGE_STANDARD = "C++11" (always uppercase), resp. 14, 17 when using premake xcode4. Similarly, cpdialect "C11" gives GCC_C_LANGUAGE_STANDARD = "C11". gnu variants are always lowercase and don't have that issue.

I spotted the cause of the bug in modules/xcode/xcode_common.lua and I am working on a fix. I'll send a PR as soon as it gets ready.

Note: Before this commit, the lower method was used at some places but when using flags, it wasn't, so the bug seems to come from before the introduction of cppdialect.

hsandt commented 7 years ago

Resolved #897