search

premasagar / pablo

Pablo is a lightweight, expressive JavaScript SVG library. Pablo creates interactive drawings with SVG (Scalable Vector Graphics), giving access to all of SVG's granularity and power.
https://pablojs.com
MIT License
413 stars 16 forks source link

Tests: some/is checks are not correct #45

Closed premasagar closed 11 years ago

premasagar commented 11 years ago

The first two tests for some/is are looking for a PabloCollection or element, but that is not what the method is supposed to do. Instead of those tests, there needs to be tests for some(fn) and some(fn, context)

premasagar commented 11 years ago

Unless some() should accept an argument of an element or collection. That could be useful(?)

AaronAcerboni commented 11 years ago

I'll work on revising these tests. I suppose it would be useful. Once again I was thinking of what jQuery could do.

http://api.jquery.com/is/

Accepts a selector, function, jqObject, htmlelement

premasagar commented 11 years ago

Yep. Fair enough. It should probably do that.

AaronAcerboni commented 11 years ago

Yep. Fair enough. It should probably do that.

Made an issue https://github.com/dharmafly/pablo/issues/49

AaronAcerboni commented 11 years ago

Closing because original issue is solved.