search

premnirmal / StockTicker

A resizable widget that shows your financial portfolio on your android home screen
GNU General Public License v3.0
442 stars 118 forks source link

Failed to fetch news #253

Open natrius opened 2 years ago

natrius commented 2 years ago

Describe the bug When opening a symbol it tells me with red "Failed to fetch news" (not data, as i said in https://github.com/premnirmal/StockTicker/issues/218 initially)

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Portfolio'
  2. Click on 'GS2C.F'; 'MVIN.F'
  3. See error

Its working for AH9.F; RI1.F for example.

Expected behavior No error and showing news at the bottom.

Smartphone (please complete the following information):

premnirmal commented 2 years ago

While this is a bug, there is not much we can do about it because the news/chart-data is fetched from different api sources (mainly google news and yahoo finance) and if they do not have the data then we have nothing to show.

natrius commented 2 years ago

I see, but GS2C.F - https://finance.yahoo.com/quote/GS2C.F?p=GS2C.F&.tsrc=fin-srch has at least one news in the last 24 hours and older ones as well. MVIN.F is the last from 7 days ago, i can see that. But in that case it would be better to write "No news news than 7 days found" or something and not "Failed to fetch news". The latter one implies an error, the first is not an error, there is simply nothing.

Thanks for you app and you answers :)

natrius commented 1 year ago

Still think "No news in the last 7 days found" would be a better message for that :) Don't want to create a new issue.