prenda-school / design-system

Implementations of the Prenda Design System (PDS).
https://main--60b7f55f55fbd4004993da4c.chromatic.com
Other
7 stars 1 forks source link

chore: upgrade nx from v17.1.3 to v19.0.1 ; upgrade storybook from v7.5.3 to v8.0.10 #726

Closed WilliamKelley closed 5 months ago

WilliamKelley commented 5 months ago

Updates Nx from v17.1.3 to v19.0.1 ~with incremental migrations to each latest major version: v17.3.2, v18.3.4, v19.0.0.~

~Only encountered one hiccup that required npm i --legacy-peer-deps when upgrading to v17.3.2. Based on https://github.com/nrwl/nx/issues/15326, this seemed like the solution.~

Edit: I revised this PR to upgrade directly from v17.1.3 to v19.0.1, accompanied by a storybook upgrade from v7.5.3 to v8.0.10 and some other manual dependency bumps (see "install deps" commit). This was to resolve the hiccup that I tried to resolve with --force or --legacy-peer-deps. I did not see a clear path out of the version mismatches without these upgrades being paired.

notion-workspace[bot] commented 5 months ago

Update design-system to Nx v19