presciencelabs / tabitha-editor

0 stars 0 forks source link

Don't do checks in a clause with an Unknown word #111

Closed craigp-atw closed 5 months ago

craigp-atw commented 5 months ago

From Richard:

This sentence should not have an error: "Your(Timothy's) mother's mother named Lois and your(Timothy's) mother named Eunice believed in Christ _implicit Jesus _implicit [before you(Timothy) believed in Christ _implicit Jesus _implicit]. " Perhaps the reason that it thought it's an error is because it doesn't recognize the noun in conjunction with "named".

Craig's response:

Yes, because 'Eunice' isn't in the ontology, it doesn't recognize it as a Noun and so doesn't recognize 'named' as the Noun-Noun relation. I'll have to think about this more, as the root issue is how we should handle words that aren't yet to added in the Ontology.

Some options:

  1. Ignore the errors because you know what's causing it
  2. Add some notation like _noun/_verb/etc after the unknown word to tell the editor to treat it like a Noun (this could also be used to disambiguate parts of speech);
  3. Skip all syntax-related checking in a clause with an unknown word, and warn the user that they need to be extra careful? (eg somehow skip all checker rules)

From Richard:

I like the last idea. Because there's an unknown word, your syntax checking can't necessarily work right. Maybe put an extra warning that the syntax checking is [turned] off.

I personally like option 2, and I think we can support both 2 and 3. ie first check if there is a disambiguation note - if so treat it as that part of speech, otherwise don't do further checking.