presciencelabs / tabitha-editor

0 stars 0 forks source link

Add more verb case frames #126

Closed craigp-atw closed 1 month ago

craigp-atw commented 1 month ago

Verb Case Frames

Added case frame and sense selection rules for the following 25 verbs:

Lookup Rules

Removed lookup rules that are now handled via case-frame rules.

Head-Noun identification

Changed a couple transform rules to better handle neighboring Noun Phrases. This improves identifying the right Noun for Verb arguments.

API data structure

The data sent over the API regarding a word's case frame arguments was changed to include the token itself that is identified as that argument. This makes debugging case frames easier and I think is generally a good idea.

Before: image

After: image

craigp-atw commented 1 month ago

do you have plans to do more in another, later PR?

Yes. There are hundreds of verbs, so I just want to chip away at them.

cloudflare-pages[bot] commented 1 month ago

Deploying editor with  Cloudflare Pages  Cloudflare Pages

Latest commit: d1c13d3
Status: ✅  Deploy successful!
Preview URL: https://8b144865.tabitha-editor.pages.dev
Branch Preview URL: https://add-more-verb-case-frames.tabitha-editor.pages.dev

View logs