search

prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.
https://react-redux-firebase.com
MIT License
2.55k stars 559 forks source link

[Typescript] getFirebase().firestore should have FirestoreStatics interface #1012

Closed zozoens31 closed 3 years ago

zozoens31 commented 3 years ago

Do you want to request a feature or report a bug?

This is a bug.

(If this is a usage question, please do not post it here—post it on gitter. If this is not a “feature” or a “bug”, or the phrase “How do I...?” applies, then it's probably a usage question.)

What is the current behavior?

Currently, getFirebase().firestore() is typed with the interface FirestoreStatics, but this is not implemented by Firebase. I wasn't able to reproduce in a fully functional sandbox because it requires a working Firebase app, but you can still see type-checking here.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via codesandbox or similar.

What is the expected behavior?

FirestoreStatics is actually implemented at the getFirebase().firestore level

Which versions of dependencies, and which browser and OS are affected by this issue? Did this work in previous versions or setups?

This should affect all versions, independently from any OS or browser. The FirestoreStatics interface was added in v3.6.0.

prescottprue commented 3 years ago

I believe