prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.

https://react-redux-firebase.com

MIT License

2.55k stars 559 forks source link

fix(types) move static firestore interface to where it's implemented #1013

Closed zozoens31 closed 3 years ago

zozoens31 commented 3 years ago

Description

See the linked issue: This fixes how Typescript describes the static elements of firestore as implemented by Firebase.

Check List

If not relevant to pull request, check off as complete

[x] All tests passing
[x] Docs updated with any changes or examples if applicable
[x] Added tests to ensure new feature(s) work properly

Relevant Issues

1012

This change is

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (v3.8.0@e716897). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             v3.8.0    #1013   +/-   ##
=========================================
  Coverage          ?   88.37%           
=========================================
  Files             ?       29           
  Lines             ?      800           
  Branches          ?        0           
=========================================
  Hits              ?      707           
  Misses            ?       93           
  Partials          ?        0

prescottprue commented 3 years ago

Will get this into the next release after testing it a bit more, thanks for the PR!

ben4523 commented 3 years ago

Will get this into the next release after testing it a bit more, thanks for the PR!

Hi, Any update about the release? I really need to access FieldValue static! Actually, we can't ... Thanks