prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.
https://react-redux-firebase.com
MIT License
2.55k stars 559 forks source link

fix(typescript): fix reloadAuth argument type and duplicate of endBefore #1031

Closed MatthewDailey closed 3 years ago

MatthewDailey commented 3 years ago

Description

This PR fixes a couple minor errors in the type declaration for react-redux-firebase. They're all very simple fixes and look like minor typos or missed spots when bulk updating types.

Screenshot of the errors fixed: Screen Shot 2020-11-30 at 5 11 49 PM

Check List

If not relevant to pull request, check off as complete

Relevant Issues

https://github.com/prescottprue/react-redux-firebase/issues/997

codecov[bot] commented 3 years ago

Codecov Report

Merging #1031 (325bbe6) into master (c72de9d) will increase coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
+ Coverage   88.33%   88.44%   +0.11%     
==========================================
  Files          29       29              
  Lines         797      805       +8     
==========================================
+ Hits          704      712       +8     
  Misses         93       93              
4sp3ll commented 3 years ago

I have huge issue with this bug:

Duplicate identifier 'endBefore'. TS2300 444 | */ 445 | where?: WhereOptions | WhereOptions[]

446 | endBefore?: FirestoreTypes.DocumentSnapshot | any | any[] | ^ 447 | /* 448 | @see https://github.com/prescottprue/redux-firestore#orderby 449 | */

When bugfix will be released? Or there is any other way to fix it?