prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.

https://react-redux-firebase.com

MIT License

2.55k stars 559 forks source link

fix(auth): fix argument type for login with credentials #1045

Closed AlexanderArvidsson closed 3 years ago

AlexanderArvidsson commented 3 years ago

Description

The current typings does not allow you to specify the credential parameter of the credentials in login. This PR changes it to match the implementation.

Check List

If not relevant to pull request, check off as complete

[x] All tests passing
[x] Docs updated with any changes or examples if applicable
[x] Added tests to ensure new feature(s) work properly

codecov[bot] commented 3 years ago

Codecov Report

Merging #1045 (597f857) into master (c72de9d) will increase coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
+ Coverage   88.33%   88.44%   +0.11%     
==========================================
  Files          29       29              
  Lines         797      805       +8     
==========================================
+ Hits          704      712       +8     
  Misses         93       93