prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.

https://react-redux-firebase.com

MIT License

2.55k stars 559 forks source link

fix(docs): correctly redirect when auth does not exist in the routing example doc #1052

Closed JonathanPorta closed 2 years ago

JonathanPorta commented 3 years ago

The current example routes a user to the /login page if they are logged in.

Based on the context of this code, I am pretty sure the intended functionality is to show how to bounce a user to the /login route when NOT logged in.

Description

Check List

If not relevant to pull request, check off as complete

[x] All tests passing
[x] Docs updated with any changes or examples if applicable
[x] Added tests to ensure new feature(s) work properly

Relevant Issues

codecov[bot] commented 3 years ago

Codecov Report

Merging #1052 (83e8746) into master (f4d9288) will decrease coverage by 0.16%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
- Coverage   88.44%   88.27%   -0.17%     
==========================================
  Files          29       29              
  Lines         805      802       -3     
==========================================
- Hits          712      708       -4     
- Misses         93       94       +1

prescottprue commented 2 years ago

Added to https://github.com/prescottprue/react-redux-firebase/pull/1149