Closed QuentinBrosse closed 1 year ago
Yeah, that totally makes sense, thanks for reporting. Haven't seen the use case so far, but it should be handled. Feel free to open a PR if you have the time.
Yes, I need it so I will try to open a PR with week. :)
@QuentinBrosse After diving into it a little bit, I realized it may take a little bit of review to make sure we keep the surface API the same (otherwise it may need to be included in the next major version which is still a ways off).
Definitely open to a PR, but I'll update if I get a chance to look more at it.
@prescottprue Has there been any progress towards this? Perhaps there is now an alternative approach to populate givenName, familyName, etc into the profile.
@CodeCutterUK I don't use this project anymore sorry. :/ Maybe @prescottprue could help.
@CodeCutterUK You should be able to use the result from the promise of your call to login to then write data off to the profile (what the profile factory does)
Do you want to request a feature or report a bug?
Feature (I think)
What is the current behavior?
When I login with facebook and the
public_profile
scope:I can access to the all the
public_profile
relative data inresponse.additionalUserInfo.profile
.What is the expected behavior?
It seems that these data are not available in the
profileFactory
arguments (neither in theuserData
nor in theprofileData
), it could be really useful in order to populate the profile with data relative to the scope(s) we chose. Is it my mistake or it is effectively the case ? If it is, I can send you a PL.Which versions of dependencies, and which browser and OS are affected by this issue? Did this work in previous versions or setups?