prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.
https://react-redux-firebase.com
MIT License
2.55k stars 559 forks source link

feat(storageActions): support firebase.storage.SettableMetadata on upload #399

Open qalqi opened 6 years ago

qalqi commented 6 years ago

Do you want to request a feature or report a bug?

After files are being uploaded with react-redux-firebase we need to provide settablemetadata for cacheControl to ensure files are not repeatedly downloaded again. Here is API reference from firebase https://firebase.google.com/docs/reference/js/firebase.storage.SettableMetadata#cacheControl

qalqi commented 6 years ago

Your work and this project are great. Are you looking to add contributors?

prescottprue commented 6 years ago

@qalqi Thank you! And yes, looking to add contributors. Also, as always, open to pull requests.

This feature should be able to be added without breaking, but just to note: there has been some talk in #368 about breaking changes that will most likely be making it into v3.0.0.