prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.

https://react-redux-firebase.com

MIT License

2.55k stars 556 forks source link

fix(docs): cleanup minor typo in useFirestoreConnect.md #949

Closed gregfenton closed 4 years ago

gregfenton commented 4 years ago

QUESTION: this page still indicates that "populate is not supported". Is this still the case for firestore?

Description

Check List

If not relevant to pull request, check off as complete

[ ] All tests passing
[ ] Docs updated with any changes or examples if applicable
[ ] Added tests to ensure new feature(s) work properly

Relevant Issues

codecov[bot] commented 4 years ago

Codecov Report

Merging #949 into master will not change coverage. The diff coverage is 25.00%.

@@           Coverage Diff           @@
##           master     #949   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files          29       29           
  Lines         797      797           
=======================================
  Hits          704      704           
  Misses         93       93

prescottprue commented 4 years ago

Population is supported in Firestore, but just not the full profile population

Agreed that it should be done, I think #915 is for updating the docs