v2.5.1 remove lifecycle warning of using componentWillMount

prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.

https://react-redux-firebase.com

MIT License

2.55k stars 559 forks source link

v2.5.1 remove lifecycle warning of using componentWillMount #969

Closed lidaof closed 4 years ago

lidaof commented 4 years ago

Description

sorry I am not a git pro....I created a branch based on 2.5.0 and then made edits based on that commit.

Check List

If not relevant to pull request, check off as complete

[ ] All tests passing
[ ] Docs updated with any changes or examples if applicable
[ ] Added tests to ensure new feature(s) work properly

Relevant Issues

dylan-cm commented 4 years ago

Where are we on this? How can I help resolve this?

prescottprue commented 4 years ago

@wurst-case Thanks for the reminder - it was just waiting on me to make a branch which is pointing to the latest v2 commit (v2.5.0). Also going to setup publishing for the v2 series to a tag so that the latest v2 can always be available

prescottprue commented 4 years ago

v2.5.1 has been released with the changes - now the previous branch and npm tag contain the current v2 version (couldn't use v2 as npm doesn't allow semver version in tags).

Will add a note to the README about this

lidaof commented 4 years ago

Hi @prescottprue @wurst-case the edits I made just removed the warnings. Have you guys consider replace componentWillMount with getDerivedStateFromProps or componentDidUpdate? I think this will make it work with React 17 in future. or people should switch to v3...