search

prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.
https://react-redux-firebase.com
MIT License
2.55k stars 559 forks source link

feat(auth): github OAuth provider option in login #971

Closed ghost closed 4 years ago

ghost commented 4 years ago

Hello, I searched around the docs and seems like the only provider options are: provider: "facebook | google | twitter | microsoft.com". It seems like there is no support for other OAuth providers like Github and I was wondering why or if that was a feature that was being looked into. The typescript declaration file also does not allow "github" as a provider

prescottprue commented 4 years ago

@zachlyoung Should for sure be supported. Open to a PR if you get a chance, otherwise I'll try to get to it when I can