search

prescottprue / react-redux-firebase

Redux bindings for Firebase. Includes React Hooks and Higher Order Components.
https://react-redux-firebase.com
MIT License
2.55k stars 559 forks source link

docs: image is broken (URL is 404) on React Native page #978

Closed gregfenton closed 4 years ago

gregfenton commented 4 years ago

Bug

The RRF docs page for React Native has a link to an image that is 404 (i.e. the image is "broken").

Repro

See the "xcode config" image just this is broken just before the title of this section of the RN page

Cause

This broke when the image it was linked to was removed from the public repository with https://github.com/react-native-community/google-signin/pull/553/files . Here is the specific diff

Possible Fixes

prescottprue commented 4 years ago

Thanks for reporting - Feel free to make a PR if you get a chance, otherwise I will get to it when I can

gregfenton commented 4 years ago

You want me to make a copy of the image and upload, or link to the historic version it used to point to? I'm unsure of your philosophy on such things. Your project, I don't want to "pollute it" on you.

Greg Fenton

email: greg.fenton@gmail.com greg.fenton@gmail.com linkedin: http://ca.linkedin.com/in/fentongreg http://ca.linkedin.com/in/fentongreg twitter: @gregfenton

On Thu, 9 Jul 2020 at 15:20, Scott Prue notifications@github.com wrote:

Thanks for reporting - Feel free to make a PR if you get a chance, otherwise I will get to it when I can

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/prescottprue/react-redux-firebase/issues/978#issuecomment-656305578, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBUCB2RQQWKHD4VNU2VD7TR2YJ63ANCNFSM4OV22ZGQ .