Closed bawahakim closed 3 years ago
Merging #979 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #979 +/- ##
=======================================
Coverage 88.33% 88.33%
=======================================
Files 29 29
Lines 797 797
=======================================
Hits 704 704
Misses 93 93
Nice work! We may want to break up the two parts you are adding here
In the v3.8.1 the types for populates
were added based on your changes! This PR was not used since it also has the UID changes which appear to be breaking (change to external API)
Because of that there are now conflicts. Feel free to open a new PR or comment on this one if you would prefer to fix the conflicts and it can be reopened
Description
This is my first public Pull Request. Please let me know if I'm doing things right!
There were some types missing for Typescript : uid for Auth, and populates for firestore queries. I also wanted to add the uid to the user profile, as I find myself importing the AuthState only for the uid. Since the doc id for the user profile has to be the auth uid, I thought it would be relevant to add it to the user profile.
I am not sure if the docs should be updated for that.
Appreciate any feedback!
Check List
If not relevant to pull request, check off as complete
Relevant Issues